Skip to content

Added Mem0 Instrumentation #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dot-agi merged 45 commits into from
Jun 13, 2025
Merged

Added Mem0 Instrumentation #1027

dot-agi merged 45 commits into from
Jun 13, 2025

Conversation

@fenilfaldu
Copy link
Contributor

@fenilfaldu fenilfaldu commented May 31, 2025 •
edited
Loading

📥 Pull Request

closes #995

📘 Description
Add Mem0 and Concurrent Futures Instrumentation(added here for testing)

  • Introduced instrumentation for the Mem0 memory management system, capturing telemetry data for memory operations across 4 core classes (Memory, MemoryClient, AsyncMemoryClient, and AsyncMemory).
  • Implemented comprehensive wrappers for 8 key Mem0 operations (add, search, get, get_all, delete, delete_all, update, history) with proper attribute extraction and telemetry capture.
  • Added logging for better traceability during instrumentation and uninstrumentation processes.

This update enhances the overall observability of memory operations and concurrent task execution within the AgentOps framework, providing full coverage for both synchronous and asynchronous Mem0 workflows.

🧪 Testing
Screenshot 2025-06-01 at 4 20 01 AM

Also submitted pr to the mem0 repository for documentation updates.

@fenilfaldu fenilfaldu requested review from bboynton97 and tcdent May 31, 2025 22:52
@codecov
Copy link

codecov bot commented May 31, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 445 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentops/instrumentation/mem0/memory.py 0.00% 196 Missing ⚠️
agentops/instrumentation/mem0/common.py 0.00% 192 Missing ⚠️
agentops/instrumentation/mem0/instrumentor.py 0.00% 43 Missing ⚠️
agentops/instrumentation/mem0/__init__.py 0.00% 14 Missing ⚠️

📢 Thoughts on this report? Let us know!

@dot-agi
Copy link
Member

dot-agi commented Jun 1, 2025

Check linting

@dot-agi
Copy link
Member

dot-agi commented Jun 1, 2025

@fenilfaldu can you add an example and a doc for this?

tcdent
tcdent previously requested changes Jun 6, 2025
View reviewed changes
Copy link
Contributor

@tcdent tcdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thorough! Just a couple notes about naming and this looks good to me.

@areibman areibman requested a review from dot-agi June 11, 2025 15:57
dot-agi
dot-agi requested changes Jun 11, 2025
View reviewed changes
Copy link
Member

@dot-agi dot-agi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: #1018 please separate the code for Mem0 instrumentation and the concurrent.futures use.

Both are related but belong in a different PR as they are both features and have independent use as well.

@dot-agi dot-agi self-requested a review June 12, 2025 15:45
@areibman areibman removed request for bboynton97 and tcdent June 13, 2025 15:48
dot-agi
dot-agi approved these changes Jun 13, 2025
View reviewed changes
Copy link
Member

@dot-agi dot-agi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @fenilfaldu!

@dot-agi dot-agi enabled auto-merge (squash) June 13, 2025 17:50
@dot-agi dot-agi dismissed tcdent’s stale review June 13, 2025 17:51

I am sorry :)

@dot-agi dot-agi merged commit 3c6b2f4 into main Jun 13, 2025
9 of 10 checks passed
@dot-agi dot-agi deleted the mem0_instrumentation branch June 13, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dot-agi dot-agi dot-agi approved these changes

@Dwij1704 Dwij1704 Dwij1704 approved these changes

@tcdent tcdent tcdent left review comments

Assignees

@fenilfaldu fenilfaldu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Integrate Mem0 memory interface

5 participants

@fenilfaldu @dot-agi @tcdent @Dwij1704